Arwin Arni <arwin_at_collab.net> writes:
> On Wednesday 04 May 2011 10:27 PM, Philip Martin wrote:
>> Arwin Arni<arwin_at_collab.net> writes:
>>
>>> Index: subversion/tests/cmdline/svnsync_tests.py
>>> ===================================================================
>>> --- subversion/tests/cmdline/svnsync_tests.py (revision 1099373)
>>> +++ subversion/tests/cmdline/svnsync_tests.py (working copy)
>>> @@ -155,7 +155,8 @@
>>>
>>>
>>> def setup_and_sync(sbox, dump_file_contents, subdir=None,
>>> - bypass_prop_validation=False, source_prop_encoding=None):
>>> + bypass_prop_validation=False, source_prop_encoding=None,
>>> + is_src_ra_local=None, is_dest_ra_local=None):
>>> """Create a repository for SBOX, load it with DUMP_FILE_CONTENTS, then create a mirror repository and sync it with SBOX. Return the mirror sandbox."""
>>>
>>> # Create the empty master repository.
>>> @@ -179,13 +180,20 @@
>>> svntest.actions.enable_revprop_changes(dest_sbox.repo_dir)
>>>
>>> repo_url = sbox.repo_url
>>> + cwd = os.getcwd()
>>> + if is_src_ra_local:
>>> + repo_url = "file://" + os.path.join(cwd, sbox.repo_dir)
>>> +
>> I suspect that might not work on Windows, look at file_scheme_prefix in
>> svntest/main.py and pathname2url. It would be better to somehow access
>> the main.py code (via sandbox.py?).
>>
>
> I did some tests and it does work on Windows as well.
How many of the many forms of Windows path did you test? I assume that
the code uses file_scheme_prefix and pathname2url because some Windows
paths require it. I don't know Windows well enough to know what is
important, so I'm not prepared to commit your alternative code.
--
Philip
Received on 2011-05-05 11:38:42 CEST