Re: svn commit: r1098694 - in /subversion/trunk/subversion: include/svn_wc.h libsvn_client/deprecated.c libsvn_wc/info.c svn/info-cmd.c

On Mon, May 2, 2011 at 2:30 PM, Greg Stein <gstein_at_gmail.com> wrote:
> On Mon, May 2, 2011 at 13:58,  <hwright_at_apache.org> wrote:
>>...
>> +      if (info2->wc_info->checksum
>> +            && info2->wc_info->checksum->kind == svn_checksum_md5)
>> +        info->checksum          = svn_checksum_to_cstring(
>> +                                        info2->wc_info->checksum, pool);
>> +      else
>> +        info->checksum          = NULL;
>
> I would note this means the checksum will be NULL for users of the old
> API (since the new API returns SHA-1 checksums). This could be viewed
> as a regression.

The docs for the old struct indicate that the field may be NULL, so
callers need to be aware of that possibility aforehand.

Also, the regression isn't caused by the above change, but rather our
decision to change which checksum we return. We've been returning
sha1's for weeks; at least now we let people know that fact. :)

-Hyrum
Received on 2011-05-02 21:39:18 CEST