[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1096619 - in /subversion/trunk/subversion/libsvn_wc: translate.c translate.h workqueue.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Tue, 26 Apr 2011 01:03:42 +0200

> -----Original Message-----
> From: hwright_at_apache.org [mailto:hwright_at_apache.org]
> Sent: maandag 25 april 2011 23:59
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1096619 - in /subversion/trunk/subversion/libsvn_wc:
> translate.c translate.h workqueue.c
>
> Author: hwright
> Date: Mon Apr 25 21:58:43 2011
> New Revision: 1096619
>
> URL: http://svn.apache.org/viewvc?rev=1096619&view=rev
> Log:
> Create a single unified function to sync file permissions with those indicated
> by locks and various properties. Use it in post-commit and other processing.
>
> Note: this removes a couple of "optimizations" in the post-commit work
> queue
> handler. However, in doing so, we greatly simplify the code, and actually
> *reduce* the number of overall database accesses, which should actually
> speed
> things up.

Before this patch we didn't change permissions on files that had non-standard permissions.

After this patch we force our set of permissions on the file. (Removing read-only in almost every case)

I would call that a behavior change; but at least it should be documented.

It looks like your patch doesn't break old wq items, but it writes new wq items that the old code can't read. (It removes the two booleans that specify the needs-lock and executable state before the propchange which allowed it to see the difference)

        Bert
Received on 2011-04-26 01:04:17 CEST

This is an archived mail posted to the Subversion Dev mailing list.