[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1092740 - /subversion/trunk/subversion/libsvn_client/commit_util.c

From: Greg Stein <gstein_at_gmail.com>
Date: Fri, 15 Apr 2011 14:30:10 -0400

Does the unit tests discover this, and didn't you run them before
committing? (tho I could see if it happened outside commit_tests, that you
might miss it)

I'm concerned because i've seen three mistakes like this today:
1. Extra param left in a call in crop.c. build failed
2. Use if targets, rather than rel_targets
3. This typo

The activity level is great, but I worry about problems that may be
introduced that are NOT found so easily.
On Apr 15, 2011 11:24 AM, <rhuijben_at_apache.org> wrote:
> Author: rhuijben
> Date: Fri Apr 15 15:24:36 2011
> New Revision: 1092740
>
> URL: http://svn.apache.org/viewvc?rev=1092740&view=rev
> Log:
> * subversion/libsvn_client/commit_util.c
> (svn_client__condense_commit_items): Fix a stupid typo that noted
> a delete under a replace as a delete under a delete.
>
> Modified:
> subversion/trunk/subversion/libsvn_client/commit_util.c
>
> Modified: subversion/trunk/subversion/libsvn_client/commit_util.c
> URL:
http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_client/commit_util.c?rev=1092740&r1=1092739&r2=1092740&view=diff
>
==============================================================================
> --- subversion/trunk/subversion/libsvn_client/commit_util.c (original)
> +++ subversion/trunk/subversion/libsvn_client/commit_util.c Fri Apr 15
15:24:36 2011
> @@ -1027,7 +1027,7 @@ svn_client__condense_commit_items(const
> && !(item->state_flags & SVN_CLIENT_COMMIT_ITEM_ADD)
> /* Last was a delete */
> && (last_item->state_flags & SVN_CLIENT_COMMIT_ITEM_DELETE)
> - && !(item->state_flags & SVN_CLIENT_COMMIT_ITEM_ADD)
> + && !(last_item->state_flags & SVN_CLIENT_COMMIT_ITEM_ADD)
> /* And last_item is an ancestor of item */
> && svn_uri_is_ancestor(last_item->url, item->url))
> {
>
>
Received on 2011-04-15 20:30:41 CEST

This is an archived mail posted to the Subversion Dev mailing list.