[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix for issue 3787

From: Noorul Islam K M <noorul_at_collab.net>
Date: Thu, 07 Apr 2011 14:46:45 +0530

Daniel Shahaf <d.s_at_daniel.shahaf.name> writes:

> Noorul Islam K M wrote on Thu, Apr 07, 2011 at 10:17:49 +0530:
>
>> Index: subversion/libsvn_client/info.c
>> ===================================================================
>> --- subversion/libsvn_client/info.c (revision 1089373)
>> +++ subversion/libsvn_client/info.c (working copy)
>> @@ -408,13 +408,17 @@
>> {
>> struct found_entry_baton fe_baton;
>> svn_error_t *err;
>> + svn_boolean_t show_exclude = FALSE;
>>
>> fe_baton.changelist_hash = changelist_hash;
>> fe_baton.receiver = receiver;
>> fe_baton.receiver_baton = receiver_baton;
>> fe_baton.wc_ctx = ctx->wc_ctx;
>>
>> - err = svn_wc__node_walk_children(ctx->wc_ctx, local_abspath, FALSE,
>> + if (depth == SVN_DEPTH_INFINITY_OR_FILES(TRUE))
>> + show_exclude = TRUE;
>> +
>> + err = svn_wc__node_walk_children(ctx->wc_ctx, local_abspath, show_exclude,
>> info_found_node_callback, &fe_baton, depth,
>> ctx->cancel_func, ctx->cancel_baton, pool);
>>
>
> Suppose that A/ and 'iota' are excluded. 'svn info --depth=immediates
> wc_dir' should also show information about both A/ and 'iota', but with
> your patch applied it doesn't show information for A/.
>
> (I didn't test 'iota' and testing the equivalent --depth=files recipe.)

The requirement is to show info for excludes if '-R' is passed. Doesn't
that mean you have to use --depth=infinity?

Thanks and Regards
Noorul
Received on 2011-04-07 11:18:46 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.