Re: svn info fails

Ivan Zhakov <ivan_at_visualsvn.com> writes:

> On Tue, Apr 5, 2011 at 22:07, Philip Martin <philip.martin_at_wandisco.com> wrote:
>> Philip Martin <philip.martin_at_wandisco.com> writes:
>>
>>> Stefan Küng <tortoisesvn_at_gmail.com> writes:
>>>
>>>> Just discovered that 'svn info' fails with a very unhelpful error message:
>>>>
>>>> svn.exe info http://svn.webdav.org/repos/projects/neon@1832 -r1833
>>>> svn: E200004: Could not convert '' into a number
>>>
>>> Not with neon, serf only:
>>>
>>> ../src/subversion/svn/info-cmd.c:581: (apr_err=200004)
>>> ../src/subversion/libsvn_client/info.c:609: (apr_err=200004)
>>> ../src/subversion/libsvn_ra_serf/serf.c:852: (apr_err=200004)
>>> ../src/subversion/libsvn_ra_serf/property.c:732: (apr_err=200004)
>>> ../src/subversion/libsvn_ra_serf/serf.c:679: (apr_err=200004)
>>> ../src/subversion/libsvn_subr/svn_string.c:775: (apr_err=200004)
>>> ../src/subversion/libsvn_subr/svn_string.c:775: (apr_err=200004)
>>> ../src/subversion/libsvn_subr/svn_string.c:775: (apr_err=200004)
>>> svn: E200004: Could not convert '' into a number
>>
>> The relevant code is:
>>
>>      if(strcmp(name, "deadprop-count") == 0)
>>        {
>>          apr_int64_t deadprop_count;
>>          SVN_ERR(svn_cstring_atoi64(&deadprop_count, val->data));
>>          entry->has_props = deadprop_count > 0;
>>        }
>>
> It seems to be my fault. I'll take a look to it tomorrow. Sorry.

Neon uses:

                 apr_int64_t prop_count = svn__atoui64(propval->data);
                 entry->has_props = (prop_count > 0);
    
So it treats '' as 0. I don't know whether that's a neon bug :)

-- 
Philip