[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1076712 - in /subversion/trunk/subversion/libsvn_wc: revision_status.c wc-queries.sql wc_db.c wc_db.h

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Thu, 03 Mar 2011 13:53:46 -0500

On 03/03/2011 01:48 PM, Stefan Sperling wrote:
> On Thu, Mar 03, 2011 at 01:40:55PM -0500, C. Michael Pilato wrote:
>> On 03/03/2011 01:15 PM, stsp_at_apache.org wrote:
>>> Author: stsp
>>> Date: Thu Mar 3 18:15:46 2011
>>> New Revision: 1076712
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1076712&view=rev
>>> Log:
>>> As a first step towards eliminating use of the node walker in
>>> svn_wc_revision_status2(), use a DB query to determine the min/max revisions
>>> of the working copy, instead of obtaining this information during the crawl.
>>
>> I was *just* making changes in this space. Why? Because this code needs to
>> ignore file externals when determining the revision range and status and
>> such. In fact, I was just getting ready to run the full test suite with the
>> attached patch, which appears to fix issue #3816[1]. Can we modify your
>> MIN_MAX sqlite statement to skip nodes which are file externals?
>
> Off-hand I have no better idea than selecting properties, parsing them,
> and determining if any of them configures a file external.
> That could be made to work but it's quite hairy.
>
> I think that, going forward, we'll need a better representation
> of externals in the DB in order to be able to make queries consider
> them in a more straightforward way.
>
> What do you think about trying to tackle that instead of adding
> little hacks here and there to fix file external bugs?
> Hacks that ultimately limit progress in wc-ng?

Well, this should be easier than parsing properties, really. I'm not trying
to ignore the directory which holds the svn:externals property, just the
file which is created as the result of that property. I'm pretty sure those
are already demarcated in the WC-NG schema in a easy-to-spot fashion.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2011-03-03 19:54:23 CET

This is an archived mail posted to the Subversion Dev mailing list.