[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1076712 - in /subversion/trunk/subversion/libsvn_wc: revision_status.c wc-queries.sql wc_db.c wc_db.h

From: Stefan Sperling <stsp_at_elego.de>
Date: Thu, 3 Mar 2011 19:50:24 +0100

On Thu, Mar 03, 2011 at 07:48:22PM +0100, Stefan Sperling wrote:
> On Thu, Mar 03, 2011 at 01:40:55PM -0500, C. Michael Pilato wrote:
> > On 03/03/2011 01:15 PM, stsp_at_apache.org wrote:
> > > Author: stsp
> > > Date: Thu Mar 3 18:15:46 2011
> > > New Revision: 1076712
> > >
> > > URL: http://svn.apache.org/viewvc?rev=1076712&view=rev
> > > Log:
> > > As a first step towards eliminating use of the node walker in
> > > svn_wc_revision_status2(), use a DB query to determine the min/max revisions
> > > of the working copy, instead of obtaining this information during the crawl.
> >
> > I was *just* making changes in this space. Why? Because this code needs to
> > ignore file externals when determining the revision range and status and
> > such. In fact, I was just getting ready to run the full test suite with the
> > attached patch, which appears to fix issue #3816[1]. Can we modify your
> > MIN_MAX sqlite statement to skip nodes which are file externals?
>
> Off-hand I have no better idea than selecting properties, parsing them,
> and determining if any of them configures a file external.
> That could be made to work but it's quite hairy.
>
> I think that, going forward, we'll need a better representation
> of externals in the DB in order to be able to make queries consider
> them in a more straightforward way.

Hmmm... until then, we could probably use this hack in the NODES table:

  /* The serialized file external information. */
  /* ### hack. hack. hack.
     ### This information is already stored in properties, but because the
     ### current working copy implementation is such a pain, we can't
     ### readily retrieve it, hence this temporary cache column.
     ### When it is removed, be sure to remove the extra column from
     ### the db-tests.

     ### Note: This is only here as a hack, and should *NOT* be added
     ### to any wc_db APIs. */
  file_external TEXT,
Received on 2011-03-03 19:51:00 CET

This is an archived mail posted to the Subversion Dev mailing list.