[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] cat_tests.py: Modify expected error string to use only error codes.

From: Stefan Sperling <stsp_at_elego.de>
Date: Mon, 21 Feb 2011 11:19:32 +0100

On Mon, Feb 21, 2011 at 12:46:25PM +0530, Noorul Islam K M wrote:
>
> Modify expected error string to use only error codes and also restrict
> one of the lines to less than 80 characters.
>
> Log
> [[[
>
> * subversion/tests/cmdline/cat_tests.py
> (cat_local_directory, cat_remote_directory, cat_nonexistent_file,
> cat_skip_uncattable, cat_unversioned_file,
> cat_url_special_characters, cat_non_existing_remote_file):
> Modify expected error string to use only error codes.
>
> (cat_skip_uncattable): Restrict line length to < 80
>
> Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
> ]]]
>

Sorry that I'm being rejecting again :)

But I think there is value in seeing the error message in the test code.
It makes it much easier for those reading the test code to follow
what kind of error the test is expecting. If all people can go by
is the error code, then they'll have to keep looking up error codes
to understand what the test is trying to do.
I think that's worse than adjusting tests when the message changes
every once in a while.
Received on 2011-02-21 11:20:13 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.