[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix failing expected error in blame_tests.py

From: Hyrum K Wright <hyrum_at_hyrumwright.org>
Date: Thu, 17 Feb 2011 14:12:44 +0000

On Thu, Feb 17, 2011 at 2:09 PM, Noorul Islam K M <noorul_at_collab.net> wrote:
>
> Log
> [[[
>
> Fix failing expected error regex.
>
> * subversion/tests/cmdline/blame_tests.py
>  (blame_non_existent_url_target): Relax regex to allow errors from
>   http: and svn: protocols.
>
> Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
> ]]]
>
>
> Index: subversion/tests/cmdline/blame_tests.py
> ===================================================================
> --- subversion/tests/cmdline/blame_tests.py     (revision 1071613)
> +++ subversion/tests/cmdline/blame_tests.py     (working copy)
> @@ -759,8 +759,7 @@
>     "     2    jrandom New contents for iota\n",
>     ]
>
> -  expected_err = "svn: warning: W160017: '/non-existent' " +  \
> -      "is not a file in revision 2\n" + \
> +  expected_err = "svn: warning: W160017: .*\n" +  \
>       ".*\nsvn: E200009: Could not perform blame on all targets " + \
>       "because some targets don't exist\n"
>   expected_err_re = re.compile(expected_err)

You could just use the expected error code, instead of having to
update the expected error message depending on the server, and any
future changes.

-Hyrum
Received on 2011-02-17 15:13:27 CET

This is an archived mail posted to the Subversion Dev mailing list.