On Mon, Feb 14, 2011 at 07:32:51PM +0530, Noorul Islam K M wrote:
> Daniel Shahaf <d.s_at_daniel.shahaf.name> writes:
> > Stefan Sperling wrote on Mon, Feb 14, 2011 at 13:25:13 +0100:
> >> On Mon, Feb 14, 2011 at 01:18:58PM +0100, Stefan Sperling wrote:
> >> > > @@ -301,5 +318,8 @@
> >> > > if (opt_state->xml && ! opt_state->incremental)
> >> > > SVN_ERR(svn_cl__xml_print_footer("lists", pool));
> >> > >
> >> > > - return SVN_NO_ERROR;
> >> > > + if (saw_a_problem)
> >> > > + return svn_error_create(SVN_ERR_BASE, NULL, NULL);
> >> > > + else
> >> > > + return SVN_NO_ERROR;
> >> > > }
> >> Oh, and I'm not sure if SVN_ERR_BASE and no message is the right
> >> thing to do here. Maybe this should be an error code such as
> >> SVN_ERR_ILLEGAL_TARGET and a message like _("Could not list all
> >> targets because some targets don't exist")?
> > Is it easily possible to give the name of the non-existent target here?
> > (i.e., "it's good for error messages to contain an %s")
> In a particular scenario there will be more than one targets which might
> fail. In those cases a warning is printed. For the user to know that
> something went wrong we are printing "svn: E200000: A problem occurred;
> see other errors for details".
I would prefer this message to be more explicit. We aren't printing
other errors as far as I can tell. We are printing warnings, not errors.
So the message saying "see other errors for details" might be confusing.
Received on 2011-02-14 15:06:44 CET