[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1068814 - /subversion/trunk/subversion/tests/libsvn_diff/diff-diff3-test.c

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: Wed, 9 Feb 2011 21:51:19 +0100

Daniel,

one comment on a comment inline.

On Wed, Feb 9, 2011 at 10:41 AM, <danielsh_at_apache.org> wrote:

> Author: danielsh
> Date: Wed Feb 9 09:41:38 2011
> New Revision: 1068814
>
> URL: http://svn.apache.org/viewvc?rev=1068814&view=rev
> Log:
> Silence the random XPASSes in the bots.
>
> * subversion/tests/libsvn_diff/diff-diff3-test.c
> (random_three_way_merge): s/400/4000/
>
> Modified:
> subversion/trunk/subversion/tests/libsvn_diff/diff-diff3-test.c
>
> Modified: subversion/trunk/subversion/tests/libsvn_diff/diff-diff3-test.c
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/libsvn_diff/diff-diff3-test.c?rev=1068814&r1=1068813&r2=1068814&view=diff
>
> ==============================================================================
> --- subversion/trunk/subversion/tests/libsvn_diff/diff-diff3-test.c
> (original)
> +++ subversion/trunk/subversion/tests/libsvn_diff/diff-diff3-test.c Wed Feb
> 9 09:41:38 2011
> @@ -2239,7 +2239,7 @@ random_three_way_merge(apr_pool_t *pool)
> gets triggered with reasonable probability. (Currently it ignores
> 50 lines or more, and empirically N=400 suffices to trigger that

         behaviour about half the time.) */

This comment needs a fix now, or needs to be rewritten.

>

- int num_lines = 400, num_src = 10, num_dst = 10;
> + int num_lines = 4000, num_src = 10, num_dst = 10;

      svn_boolean_t *lines = apr_pcalloc(subpool, sizeof(*lines) *
> num_lines);
> struct random_mod *src_lines = apr_palloc(subpool,
> sizeof(*src_lines) *
> num_src);
>
>
>
Lieven
Received on 2011-02-09 21:52:20 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.