[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Proposal: Use decorators in test suite for XFail, Skip, etc

From: Greg Stein <gstein_at_gmail.com>
Date: Fri, 4 Feb 2011 14:09:35 -0500

On Fri, Feb 4, 2011 at 12:15, Hyrum K Wright <hyrum_at_hyrumwright.org> wrote:
>...
> We currently mark tests XFail (or Skip, or something else) by wrapping
> them in the test_list in the test suite.  Rather than doing it there,
> I think it makes more sense to use Python's decorator syntax to mark
> tests as XFail right at their definition, rather than down in the test
> list.  Keeping all attributes of a test in close proximity is a Good
> Thing, imo.  Attached is a patch which demonstrates this.

Sure.

>...
> +++ subversion/tests/cmdline/basic_tests.py     (working copy)

XFail = svntest.testcase.xfail_deco

> @@ -1961,6 +1961,7 @@
>                                         expected_status)
>
>  # Test for issue #1199
> +@svntest.testcase.xfail_deco

@XFail

>...
Received on 2011-02-04 20:10:14 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.