[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Roadmap : 1.7 Release Status : Test Review : XFails

From: 'Daniel Shahaf' <d.s_at_daniel.shahaf.name>
Date: Thu, 3 Feb 2011 01:56:53 +0200

Stefan Sperling wrote on Wed, Feb 02, 2011 at 14:59:44 +0100:
> On Wed, Feb 02, 2011 at 02:12:55PM +0100, Bert Huijben wrote:
> >
> >
> > > -----Original Message-----
> > > From: Stefan Sperling [mailto:stsp_at_elego.de]
> > > Sent: woensdag 2 februari 2011 11:52
> > > To: Daniel Shahaf
> > > Cc: Paul Burba; Subversion Development; dannas_at_dannas.name
> > > Subject: Re: Roadmap : 1.7 Release Status : Test Review : XFails
> > >
> > > On Wed, Feb 02, 2011 at 05:16:14AM +0200, Daniel Shahaf wrote:
> > > > > LISTING: patch_tests.py
> > > > >
> > > > > Test # Mode Test Description
> > > > > ------ ----- ----------------
> > > > > 29 XFAIL patch doesn't append newline to properties
> > > > > Issue #: None
> > > > > Target Milestone: N/A
> > > > > Thread: N/A
> > > > > Log: r1033709
> > > > > Point Person: danielsh
> > > >
> > > > I added it after IRC discussion, but IIRC dannas/stsp later had other
> > > > ideas in this area. Not sure what the current plan is.
> > >
> > > The plan for patch is to leave it as is until we've released 1.7.
> > > IMO we shouldn't bother changing anything in patch at this point,
> > > unless it's a very severe bug (e.g. a crash or something equally bad).
> >
> > Wouldn't this be a breaking change if we update it later?
>
> Reading the test description and log message, I don't even get what
> this is really about. What's the problem? Does svn patch append newlines
> that shouldn't be there? Does it not append newlines where it should?

The latter. There are two tests that differ only by one using
a property with a trailing newline and one a property without a trailing
newline; one of them fails and one passes.

(Use-cases: svn:ignore for with, svn:keywords for without)
Received on 2011-02-03 01:01:30 CET

This is an archived mail posted to the Subversion Dev mailing list.