Re: svn commit: r1066087 - in /subversion/trunk/subversion/libsvn_subr: dirent_uri.c target.c

On Tue, Feb 01, 2011 at 08:14:13PM +0100, Stefan Sperling wrote:
> And here, we use it:
>
> > + *pcommon = svn_uri_get_longest_ancestor(*pcommon, absolute, pool);
>
> See http://ci.apache.org/builders/svn-slik-w2k3-x64-ra/builds/1628/steps/Test%20fsfs%2Bserf/logs/faillog

Actually, that link doesn't provide useful information.
Here's how it failed:
0x0000000203697195 in svn_uri_get_longest_ancestor (
     uri1=0x2012d3c48 "/home/stsp/svn/svn-trunk/subversion/tests/libsvn_subr/z/A/file",
     uri2=0x20313a060 "http://host/A/C/D", pool=0x20c597028)
     at subversion/libsvn_subr/dirent_uri.c:1410
1410 assert(svn_uri_is_canonical(uri1, NULL));

> Now we could crash. But in the failing test *pcommon happens to
> point to some string from a previous invocation of this function.
> We ended up using that value, which happened to be a dirent,
> causing the assertion failure. Fixed in r1066143.
>
> > + else
> > + *pcommon = svn_dirent_get_longest_ancestor(*pcommon, absolute,
> > + pool);
> > + }
Received on 2011-02-01 20:22:24 CET