Re: I need to extend svn_subst_translate_string2()

On Fri, Jan 14, 2011 at 09:24:10AM -0800, Danny Trebbien wrote:
> For a while I was trying to figure out why one of the svnsync tests
> were failing with "svnsync: Inconsistent line ending style". I then
> realized that because normalize_string() in sync.c now only calls
> svn_subst_translate_string2(), I need to modify it to accept a REPAIR
> parameter.
>
> svn_subst_translate_string2() was the function that I added with my
> first patch that was committed. Do I need to rename
> svn_subst_translate_string2() to svn_subst_translate_string3(), move
> svn_subst_translate_string2() to deprecated.c, etc., or can I just add
> the parameter to svn_subst_translate_string2()?

If the API you've added is marked as new in 1.7 it can still be changed.
We are free to change public APIs until they have been released.

Stefan
Received on 2011-01-14 18:28:43 CET