[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1057908 - /subversion/trunk/subversion/libsvn_client/patch.c

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 12 Jan 2011 00:13:13 +0100

On Tue, Jan 11, 2011 at 05:04:45PM -0600, Hyrum K Wright wrote:
> On Tue, Jan 11, 2011 at 4:56 PM, <stsp_at_apache.org> wrote:
> > @@ -2552,32 +2539,43 @@ delete_empty_dirs(apr_array_header_t *ta
> >       /* Rebuild the empty dirs list, replacing empty dirs which have
> >        * an empty parent with their parent. */
> >       again = FALSE;
> > -      empty_dirs_copy = apr_array_copy(iterpool, empty_dirs);
> > -      apr_array_clear(empty_dirs);
> > -      for (i = 0; i < empty_dirs_copy->nelts; i++)
> > +      empty_dirs_copy = apr_hash_copy(iterpool, empty_dirs);
> > +      apr_hash_clear(empty_dirs);
>
> Should use svn_hash__clear() here, since apr_hash_clear() isn't
> defined in APR 0.9.
>

Thanks, the bots have already complained about this as well and I've
fixed it in r1057912.

Stefan
Received on 2011-01-12 00:13:55 CET

This is an archived mail posted to the Subversion Dev mailing list.