[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] '--version --quiet' should display only the version info in svnadmin, svnlook, svnsync, svndumpfilter, svnversion, svnserve

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Wed, 5 Jan 2011 16:00:38 +0200

Prabhu,

Daniel Shahaf wrote on Wed, Jan 05, 2011 at 15:11:35 +0200:
> Prabhu Gnana Sundar wrote on Wed, Jan 05, 2011 at 17:12:46 +0530:
> > Hi all,
> >
> > Currently svnadmin, svnlook, svnsync, svndumpfilter, svnversion,
> > svnserve show the entire version information even if '--version --quiet'
> > is given as command.
> >
> > The '--quiet' option has *not* been handled so far.
> >
> > This patch would make svnadmin, svnlook, svnsync, svndumpfilter,
> > svnversion, svnserve '--version --quiet' to display *only* the version
> > number(info) just like 'svn --version --quiet' does.
> >
>
> Heh. This is one of the things I looked into, back before I was
> formally involved with the project... (as patch manager and later
> a committer)
>
> But I never sent in a patch for this, because I reckoned that a patch
> that just adds a --quiet option everywhere (and uses it just for
> --version --quiet) would serve more as a 'practice for Daniel in sending
> patches' and less as 'a patch that Subversion needs'. So I looked
> for more 'real' patches (eg, copy_tests 48) to work on.

Just to avoid any misunderstanding, the the above wasn't meant to
discourage you from proceeding with this submission; I just enjoyed
recalling the Good Old Days (from before I was a committer).

As I said in the last paragraph, if your goal is not specifically this
patch but rather you are in "I look for open issues that I can handle"
mode, then I encourage you to move on to larger issues.

> Not to say that this patch is unnecessary (maybe you have a usecase
> wherein it's required), but if you're looking to cut your teeth, I can
> suggest a few more challening things to work on. :-)
>
> > I have attached the patch and the log message with this mail. Please
> > give your views on this.
> >
> >
> > Thanks and regards
> > Prabhu
>
Received on 2011-01-05 15:04:07 CET

This is an archived mail posted to the Subversion Dev mailing list.