[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Replace stale comments about svn_path_condense_targets with svn_uri_condense_targets/svn_dirent_condense_targets

From: vijay <vijay_at_collab.net>
Date: Mon, 27 Dec 2010 15:46:45 +0530

On Monday 27 December 2010 03:32 PM, Noorul Islam K M wrote:
> vijay<vijay_at_collab.net> writes:
>
>> Hi,
>>
>> This patch replaces few stale comments about svn_path_condense_targets
>> with svn_uri_condense_targets/svn_dirent_condense_targets in
>> libsvn_client/locking_commands.c:organize_lock_targets().
>>
>> Thanks& Regards,
>>
>>
>> Index: subversion/libsvn_client/locking_commands.c
>> ===================================================================
>> --- subversion/libsvn_client/locking_commands.c (revision 1053004)
>> +++ subversion/libsvn_client/locking_commands.c (working copy)
>> @@ -201,8 +201,8 @@
>> targets, TRUE, pool, pool));
>> }
>>
>> - /* svn_path_condense_targets leaves paths empty if TARGETS only had
>> - 1 member, so we special case that. */
>> + /* svn_uri_condense_targets/svn_dirent_condense_targets leaves uris/dirents
>> + * empty if TARGETS only had 1 member, so we special case that. */
>> if (apr_is_empty_array(rel_targets))
>> {
>> const char *parent, *base;
>> @@ -273,7 +273,7 @@
>> SVN_ERR(svn_uri_condense_targets(&common_url,&rel_urls, urls,
>> FALSE, pool, pool));
>>
>> - /* svn_path_condense_targets leaves paths empty if TARGETS only had
>> + /* svn_uri_condense_targets leaves uris empty if TARGETS only had
>> 1 member, so we special case that (again). */
>> if (apr_is_empty_array(rel_urls))
>> {
>>
>> [[[
>> Replace stale comments about svn_path_condense_targets with
>> svn_uri_condense_targets/svn_dirent_condense_targets.
>>
>> * subversion/libsvn_client/locking_commands.c:
>> (organize_lock_targets): Update the comment.
>>
>> Patch by: Vijayaguru G<vijay{_AT_}collab.net>
>> ]]]
>
> I think I already submitted a patch for this. See here
>
> http://svn.haxx.se/dev/archive-2010-12/0499.shtml
>
Sorry. I didn't follow that thread. So please ignore this patch.

Thanks & Regards,
Vijayaguru
> Thanks and Regards
> Noorul
Received on 2010-12-27 11:17:25 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.