[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1044028 - in /subversion/trunk/subversion: libsvn_client/ svn/

From: Branko ─îibej <brane_at_xbc.nu>
Date: Fri, 10 Dec 2010 20:35:08 +0100

On 10.12.2010 20:31, Noorul Islam K M wrote:
> Daniel Shahaf <d.s_at_daniel.shahaf.name> writes:
>
>> I don't really mind having the input checks both at the client library
>> and in the cmdline client --- though, of course, having them just in the
>> former should be sufficient --- but this time it's straight code
>> duplication:
>>
> Even though both the message are same, the error type is different. In
> command line we use SVN_ERR_CL_ARG_PARSING_ERROR and in client API
> SVN_ERR_ILLEGAL_TARGET. The reason to check both at command line and
> client API is that, this will protect users who directly use API calls.
>
> Thanks and Regards
> Noorul

That code should be only in libsvn_client, IMHO. If the client wants to
wrap the generic error with its own specific one, it can; but there's no
need for the code to be in more than one place.

-- Brane
Received on 2010-12-10 20:35:50 CET

This is an archived mail posted to the Subversion Dev mailing list.