[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Input validation observations

From: Noorul Islam K M <noorul_at_collab.net>
Date: Tue, 07 Dec 2010 21:55:58 +0530

Julian Foad <julian.foad_at_wandisco.com> writes:

> On Sat, 2010-12-04, Noorul Islam K M wrote:
>
>> Julian Foad <julian.foad_at_wandisco.com> writes:
>> > On Fri, 2010-12-03, Noorul Islam K M wrote:
>> >> Julian Foad <julian.foad_at_wandisco.com> writes:
>> >> > I think we should change this behaviour and make "svn update" throw an
>> >> > error if any target is a URL.
>> >>
>> >> Attached is the patch for same.
>> > [...]
>> >> Make 'svn update' verify that URLs are not passed as targets.
>> >>
>> >> * subversion/svn/update-cmd.c,
>> >> subversion/libsvn_client/update.c:
>> >> (svn_cl__update, svn_client_update4): Raise an error if a URL was
>> >> passed. Remove code that notifies 'Skipped' message for URL targets.
>> > [...]
>
>> Please find attached the updated patch.
>
> Hi Noorul.
>
> Several tests fail with this patch.
>
> FAIL: basic_tests.py 4: basic update command
> FAIL: commit_tests.py 56: 'svn commit --changelist=foo' above a
> conflict
> FAIL: externals_tests.py 15: should not be able to mv or rm a file
> external
> FAIL: externals_tests.py 16: place a file external into a directory
> external
> [...]
>
> Before you send a patch, always run the test suite ("make check" or
> similar) and check that all tests pass. If you have done no testing or
> different testing or you found failures but want to send the patch
> anyway, then simply say so in the email, so we know. If you don't say
> anything, we will assume you ran the test suite and all tests pass.
>

I will keep this in mind. I actually added a test case for this as part
of the patch. My mistake to not run the entire test suite. I will send
follow-up patch with modified test cases.

Thanks and Regards
Noorul
Received on 2010-12-07 17:26:55 CET

This is an archived mail posted to the Subversion Dev mailing list.