On Fri, 2010-12-03 at 19:15 +0530, Noorul Islam K M wrote:
> Julian Foad <julian.foad_at_wandisco.com> writes:
> > Noorul Islam K M wrote:
> >> Julian Foad <julian.foad_at_wandisco.com> writes:
> >> > * "svn mkdir ^/ a" -> "Illegal repository URL 'a'"; should say "can't
> >> > mix URL and local targets"?
> > [...]
> > Does this validation make the check at the beginning of mkdir_urls()
> > redundant? If so, we should get rid of it.
>
> Attached is the modified patch.
Committed in r1041900.
Thanks!
- Julian
> Log
>
> [[[
> Make 'svn mkdir' verify that both working copy paths and URLs are
> not passed.
>
> * subversion/svn/mkdir-cmd.c,
> subversion/libsvn_client/add.c
> (svn_cl__mkdir, svn_client_mkdir4): Raise an error if both working
> copy paths and URLs are passed.
> (mkdir_urls): Remove redundant code.
>
> * subversion/tests/cmdline/input_validation_tests.py
> (invalid_mkdir_targets, test_list): New test
>
> Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
> ]]]
Received on 2010-12-03 17:34:32 CET