[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Input validation observations

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Fri, 03 Dec 2010 11:09:29 -0500

On 12/03/2010 06:51 AM, Julian Foad wrote:
> Noorul Islam K M wrote:
>> Julian Foad <julian.foad_at_wandisco.com> writes:

[...]

>> Index: subversion/svn/info-cmd.c
>> ===================================================================
>> --- subversion/svn/info-cmd.c (revision 1041293)
>> +++ subversion/svn/info-cmd.c (working copy)
>> @@ -584,12 +584,8 @@
>> }
>> else if (err->apr_err == SVN_ERR_RA_ILLEGAL_URL)
>> {
>> - SVN_ERR(svn_cmdline_fprintf
>> - (stderr, subpool,
>> - _("%s: (Not a valid URL)\n\n"),
>> - svn_path_is_url(truepath)
>> - ? truepath
>> - : svn_dirent_local_style(truepath, pool)));
>> + SVN_ERR(svn_cmdline_fprintf (stderr, subpool,
>> + _("%s\n\n"), err->message));
>
> Unfortunately we cannot assume that err->message is a good user-friendly
> description of the problem.

I've tweaked the documentation for svn_error_t in r1041891 to hopefully
point folks away from directly accessing err->message (among other things).

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2010-12-03 17:10:09 CET

This is an archived mail posted to the Subversion Dev mailing list.