[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1041230 - /subversion/trunk/subversion/include/svn_checksum.h

From: Blair Zajac <blair_at_orcaware.com>
Date: Wed, 01 Dec 2010 22:57:15 -0800

On 12/1/10 4:38 PM, stefan2_at_apache.org wrote:
> Author: stefan2
> Date: Thu Dec 2 00:38:17 2010
> New Revision: 1041230
>
> URL: http://svn.apache.org/viewvc?rev=1041230&view=rev
> Log:
> Fix the svn_checksum_to_cstring() docstring to actually say what
> was intended. Also, make clear that the behavior is new for 1.7 and
> trying to use it in 1.6 will cause segfaults.
>
> * subversion/include/svn_checksum.h
> (svn_checksum_to_cstring): fix docstring

What happens if somebody makes a svn tool that is compiled and built against the
new 1.7 behavior and then it is backported to 1.6, it may core dump.

Should we add a svn_checksum_to_cstring2() instead with the new behavior or
backport this change to 1.6? But even then we'll have 1.6 versions with
different behavior. It seems making a new svn_checksum_to_cstring2() is better.

Regards,
Blair
Received on 2010-12-02 07:57:56 CET

This is an archived mail posted to the Subversion Dev mailing list.