[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1038477 - /subversion/trunk/tools/dist/collect_sigs.py

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Wed, 24 Nov 2010 19:40:40 +0200

Hyrum K. Wright wrote on Wed, Nov 24, 2010 at 08:34:01 -0600:
> On Tue, Nov 23, 2010 at 10:55 PM, <danielsh_at_apache.org> wrote:
> > Author: danielsh
> > Date: Wed Nov 24 04:55:25 2010
> > New Revision: 1038477
> >
> > URL: http://svn.apache.org/viewvc?rev=1038477&view=rev
> > Log:
> > * tools/dist/collect_sigs.py
> >  (save_valid_sig, split):  Add a \n to flush the "--END PGP SIG--" line.
> >
> > Modified:
> >    subversion/trunk/tools/dist/collect_sigs.py
> >
> > Modified: subversion/trunk/tools/dist/collect_sigs.py
> > URL: http://svn.apache.org/viewvc/subversion/trunk/tools/dist/collect_sigs.py?rev=1038477&r1=1038476&r2=1038477&view=diff
> > ==============================================================================
> > --- subversion/trunk/tools/dist/collect_sigs.py (original)
> > +++ subversion/trunk/tools/dist/collect_sigs.py Wed Nov 24 04:55:25 2010
> > @@ -129,12 +129,13 @@ def split(sigs):
> >     if lines or '--BEGIN' in line:
> >       lines.append(line)
> >     if '--END' in line:
> > -      yield "\n".join(lines)
> > +      yield "\n".join(lines) + "\n"
> >       lines = []
> >
> >  def save_valid_sig(filename, signature):
> > +  # Add \n to flush.  (For some reason, .flush() didn't do the trick.)
> >   f = open(os.path.join(config.sigdir, filename + '.asc'), 'a')
> > -  f.write(signature)
> > +  f.write(signature + "\n")
>
> Why not f.flush() ?
>

I had tried to flush+close but it had no effect.

> >
> >
> >  def verify_sig_for_file(signature, filename):
> >
> >
> >
Received on 2010-11-24 18:44:09 CET

This is an archived mail posted to the Subversion Dev mailing list.