[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: The new "warning: The depth of this commit is 'empty', but copied dirs ..."

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Wed, 17 Nov 2010 13:47:05 +0000

On Wed, 2010-11-17, Stefan Sperling wrote:
> On Wed, Nov 17, 2010 at 12:04:21PM +0000, Julian Foad wrote:
> > I think it would be better if we only issue this warning when the
> > proposed commit does in fact include a copy, otherwise it's going to be
> > too much noise.
> >
> > Thoughts?
>
> The warning is printed very early in the commit process, way before
> the commit targets are harvested. Printing the warning at a later stage
> is much harder to do, especially in light of backporting the change
> to 1.6.x because that would require API changes (the backport has
> happened in 1.6.13).
>
> But yes, I agree that it would be better to print the warning only
> if the commit harvester has actually picked up a copy. We could file
> an issue with 1.7.0 milestone for this, and I'll try to take a crack
> at it if I can find the time.

Great, thanks. Issue #3752
<http://subversion.tigris.org/issues/show_bug.cgi?id=3752>, "Warning
about committing copied dir at depth 'empty'". I won't hold you to
working on it, of course.

- Julian
Received on 2010-11-17 14:47:48 CET

This is an archived mail posted to the Subversion Dev mailing list.