[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1033622 - /subversion/trunk/subversion/tests/libsvn_fs_fs/fs-pack-test.c

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Wed, 10 Nov 2010 20:19:22 +0200

cmpilato_at_apache.org wrote on Wed, Nov 10, 2010 at 18:08:17 -0000:
> + err = svn_fs_recover(REPO_NAME, NULL, NULL, pool);
> + if (! err)
> + return svn_error_create(SVN_ERR_TEST_FAILED, NULL,
> + "Expected SVN_ERR_FS_CORRUPT error; got none");
> + if (err->apr_err != SVN_ERR_FS_CORRUPT)
> + return svn_error_create(SVN_ERR_TEST_FAILED, err,
> + "Expected SVN_ERR_FS_CORRUPT error; got:");

Suppose err->apr_err == SVN_ERR_FS_CORRUPT, won't that leak the error?

> return SVN_NO_ERROR;
Received on 2010-11-10 19:22:43 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.