[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Canonicalize dirent/URL before passing to client API

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Wed, 10 Nov 2010 14:04:24 +0000

On Wed, 2010-11-10, Noorul Islam K M wrote:
> [[[
>
> Canonicalize dirent/URL before passing to client API

Thanks, Noorul. I haven't checked this out yet, but it looks good.

In several places you write:

> SVN_ERR(svn_cl__revprop_prepare(&opt_state->start_revision, targets,
> &URL, ctx, pool));
> + URL = svn_uri_canonicalize(URL, pool);

It seems to me that that canonicalization would be better in
svn_cl__revprop_prepare(). Do you agree?

I'll check and commit this patch later. The above change can be a
follow-up.

- Julian
Received on 2010-11-10 15:05:09 CET

This is an archived mail posted to the Subversion Dev mailing list.