[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

svn_client_delete with multiple targets

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Tue, 02 Nov 2010 20:20:43 +0100

Hi,

I found a small problem in svn_client_delete4() when passing multiple
urls to delete.

If at least one of the urls contain escaped chars, then the deletion
fails. The reason is in libsvn_client/delete.c, line 209:
       item_url = svn_path_url_add_component2(common, path, subpool);

that line combines the common root of all delete targets with the
relative path of each of the targets, but it escapes those again.

I thought that the svn API requires all urls passed to it to be already
escaped - this at least is required if only one single target is passed
to the API. Only if multiple targets are passed, then those get escaped
again.

The problem isn't just on trunk but also in 1.6.x.

Does this mean that for multiple targets clients must not escape the
urls? Not sure if this is a bug, but it's at least an inconsistency in
the API.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
Received on 2010-11-02 20:21:29 CET

This is an archived mail posted to the Subversion Dev mailing list.