[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r984984 - /subversion/branches/performance/subversion/libsvn_repos/reporter.c

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Thu, 14 Oct 2010 14:45:46 -0500

On Thu, Aug 12, 2010 at 4:25 PM, <stefan2_at_apache.org> wrote:
> Author: stefan2
> Date: Thu Aug 12 21:25:11 2010
> New Revision: 984984
>
> URL: http://svn.apache.org/viewvc?rev=984984&view=rev
> Log:
> Eliminate redundant revprop lookups: Exports / checkouts often
> contain multiple nodes from the same revision. Therefore, we
> cache essential revision info in the report baton for as long as
> the report is running.
>
> As a neat side-effect, this will also fix inconsistencies created by
> changing revprops (in a parallel request) while a report is running.

A nice change. In reviewing it for merge to trunk, I noticed that
cached information is never evicted. Do we assume that the number of
revisions touched won't be significant, so we don't need to worry
about the size of the cache (and hence memory usage) blowing up?

-Hyrum
Received on 2010-10-14 21:46:27 CEST

This is an archived mail posted to the Subversion Dev mailing list.