Re: [Merge request] Merge r985477 from performance branch

Branko Čibej <brane_at_xbc.nu> writes:

> Got into this a bit late, sorry, but I'm not at all happy about this
> change.
>
> If we ignore the issue with long-running SVN processes ... ok, let's
> assume that changing umask requires that you restart daemons ...
>
> I cannot ignore two issues:
>
> * The default perms will come from the temp directory, not the WC
> directory. These perms may not be the same, defaults may be
> different on different volumes.
> * Even if we took the perms off of the current WC and stored them, a
> long-running process can work with multiple WCs at the same times
> and there's no guarantee that the default file perms are the same
> on all of them.

Those are valid concerns but not really an issue with patch which
merely caches the permissions and doesn't change the value that gets
cached. Also it was introduced as a server optimisation so repository
permissions are affected as well as working copy permissions.

-- 
Philip