Re: svn commit: r1005052 - /subversion/trunk/subversion/tests/libsvn_wc/entries-compat.c

On Wed, Oct 6, 2010 at 10:22, <julianfoad_at_apache.org> wrote:
> Author: julianfoad
> Date: Wed Oct  6 14:22:11 2010
> New Revision: 1005052
>
> URL: http://svn.apache.org/viewvc?rev=1005052&view=rev
> Log:
> * subversion/tests/libsvn_wc/entries-compat.c
>  (TESTING_DATA): Remove erroneous spaces from within a checksum blob.
>    Make indentation and line breaks more consistent with each other and
>    with db-test.c, at the expense of one line going over 80 characters.

Because you're mixing functional and whitespace changes, this commit
is effectively unreviewable using this email. To review it, I would
have to go to the cmdline and use the -x -b switch to review the
functionality. That isn't going to happen.

While this is a minor fix, and doesn't really require careful review,
the process of joining function and whitespace changes into a single
commit is problematic and should be avoided.

>...

Thanks,
-g
Received on 2010-10-06 19:51:59 CEST