[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] Use neon's system proxy detection if not explicitly specified

From: Jon Foster <Jon.Foster_at_cabot.co.uk>
Date: Mon, 27 Sep 2010 12:33:05 +0100

Hi,

+ if test -n ["`echo "$NEON_VERSION" | grep '^0\.29\.'`"] ; then
+ AC_DEFINE_UNQUOTED([SVN_NEON_0_29], [1],
+ [Define to 1 if you have Neon 0.29 or later.])
+ fi

The comment says "0.29 or later" (which I think is right), but
the test looks like it's checking for Neon 0.29 exactly. Will
this go wrong with Neon 0.30 or 1.00?

Kind regards,

Jon

-----Original Message-----
From: Dominique Leuenberger [mailto:dominique_at_leuenberger.net]
Sent: 27 September 2010 12:06
To: dev_at_subversion.apache.org
Subject: [PATCH] Use neon's system proxy detection if not explicitly
specified

Hi All,

[[[
Use Neon's system_proxy autodetection if no proxy has been explicitly
specified.
]]]

As a notebook user I'm of course using it on different
locations/networks and one thing rather annoying is that subversion only
cares for it's own configuration file when it comes to proxy
connections.

Since version 0.29.0 of libneon, it features a ne_session_system_proxy
API, which allows to transparently have the proxy settings filled, based
on what you have configured in your gnome/kde session (it uses libproxy
in the background for this). Should you happen to run subversion on any
different kind of session, is is falling back to using envvar.

I've been working with subversion the last few days with this
modification and it served me a lot, as I do only have to change my
gnome session's proxy settings now. svn is inheriting them, avoiding the
need to configure this file in plus (one location to rule them all!).

I'd be really glad if you would consider merging this patch (I wrote it
initially for 1.6.12, then later ported to svn trunk, which is slightly
different... I only tested the 1.6.12 version of the patch!).

Both patches are attached here for reference.

Best regards,
Dominique

______________________________________________________________________
This email has been scanned by the MessageLabs Email Security System.
For more information please visit http://www.messagelabs.com/email
______________________________________________________________________

**********************************************************************
This email and its attachments may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Cabot Communications Ltd.

If you are not the intended recipient of this email and its attachments, you must take no action based upon them, nor must you copy or show them to anyone.

Cabot Communications Limited
Verona House, Filwood Road, Bristol BS16 3RY, UK
+44 (0) 1179584232

Co. Registered in England number 02817269

Please contact the sender if you believe you have received this email in error.

**********************************************************************

______________________________________________________________________
This email has been scanned by the MessageLabs Email Security System.
For more information please visit http://www.messagelabs.com/email
______________________________________________________________________
Received on 2010-09-27 13:33:47 CEST

This is an archived mail posted to the Subversion Dev mailing list.