[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1000816 - /subversion/trunk/subversion/libsvn_wc/copy.c

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Fri, 24 Sep 2010 15:00:17 +0100

On Fri, 2010-09-24 at 13:45 +0100, Philip Martin wrote:
> julianfoad_at_apache.org writes:
>
> > Author: julianfoad
> > Date: Fri Sep 24 11:27:36 2010
> > New Revision: 1000816
>
> > + /* ### Huh? This looks like it's expected to overwrite the temp file
> > + *DST_ABSPATH, but it would return an error if the destination
> > + exists. And same for svn_io_dir_make() below. What gives? */
>
> The file has already been closed and deleted because NULL is passed to
> svn_io_open_unique_file3.

Philip, thanks! Even after you said this it took me a while to see how
the file got deleted, so I've updated the doc string of
svn_io_open_unique_file3() to mention that behaviour.

r1000874.

- Julian
Received on 2010-09-24 16:01:07 CEST

This is an archived mail posted to the Subversion Dev mailing list.