[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1000370 - /subversion/trunk/subversion/libsvn_wc/wc-queries.sql

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Thu, 23 Sep 2010 18:41:01 +0100

Greg Stein <gstein_at_gmail.com> writes:

> On Thu, Sep 23, 2010 at 05:16, <philip_at_apache.org> wrote:
>> Author: philip
>> Date: Thu Sep 23 09:16:28 2010
>> New Revision: 1000370
>>
>> URL: http://svn.apache.org/viewvc?rev=1000370&view=rev
>> Log:
>> Use lower case in SQL queries instead of mixing upper and lower
>> cases inconsistently.  No functional change.
>
> I preferred the form with uppercase keywords and table names. It makes
> it much easier to see which columns are selected, and to read the
> expressions in WHERE clauses.
>
> IOW, I disagree with this change and would actually prefer fixing the
> all-lowercase queries that were scattered around.

I don't mind whether we use upper case or lower case, I just want all
keywords in the same case, all table names in the same case and all
column names in the same case (and those 3 categories don't have to be
the same). I chose lower case simply because there appeared to be
more lower case than uppercase. I'm prepared to make the change to
upper case if that is what people want. Or you can do it :)

-- 
Philip
Received on 2010-09-23 19:41:58 CEST

This is an archived mail posted to the Subversion Dev mailing list.