[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r999507 - in /subversion/trunk/subversion: svnrdump/dump_editor.c tests/cmdline/svnrdump_tests.py

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Tue, 21 Sep 2010 19:28:57 +0200

artagnon_at_apache.org wrote on Tue, Sep 21, 2010 at 17:11:51 -0000:
> Author: artagnon
> Date: Tue Sep 21 17:11:50 2010
> New Revision: 999507
>
> URL: http://svn.apache.org/viewvc?rev=999507&view=rev
> Log:
> * subversion/svnrdump/dump_editor.c
> (delete_entry): Duplicate the string that we're using as the key of
> the hashtable before entering it into the hashtable.
> * subversion/tests/cmdline/svnrdump_tests.py
> (test_list): Mark the url_encoding_dump test as passing.
>
> Modified:
> subversion/trunk/subversion/svnrdump/dump_editor.c
> subversion/trunk/subversion/tests/cmdline/svnrdump_tests.py
>
> Modified: subversion/trunk/subversion/svnrdump/dump_editor.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svnrdump/dump_editor.c?rev=999507&r1=999506&r2=999507&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/svnrdump/dump_editor.c (original)
> +++ subversion/trunk/subversion/svnrdump/dump_editor.c Tue Sep 21 17:11:50 2010
> @@ -97,17 +97,15 @@ make_dir_baton(const char *path,
> struct dir_baton *new_db = apr_pcalloc(pool, sizeof(*new_db));
> const char *abspath;
>
> - /* Disallow a path relative to nothing. */
> - SVN_ERR_ASSERT_NO_RETURN(!path || pb);
> -

Why did you drop this assertion?

Also; if you intend to move it back, SVN_ERR_ASSERT() would be better
(for when this code becomes a library function).

> /* Construct the full path of this node. */
> if (pb)
> abspath = svn_uri_join("/", path, pool);
> else
> - abspath = "/";
> + abspath = apr_pstrdup(pool, "/");
>

It is most likely unnecessary to duplicate a static string constant. :-)
Received on 2010-09-21 19:30:18 CEST

This is an archived mail posted to the Subversion Dev mailing list.