[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r993183 - in /subversion/trunk/subversion: include/ libsvn_diff/ libsvn_ra_serf/ libsvn_subr/ mod_dav_svn/reports/

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Wed, 15 Sep 2010 14:27:21 +0100

Also printf formatting type mismatches:

subversion/libsvn_subr/svn_string.c: In function
'svn_cstring_strtoui64':
subversion/libsvn_subr/svn_string.c:662: format '%lu' expects type 'long
unsigned int', but argument 5 has type 'apr_uint64_t'
subversion/libsvn_subr/svn_string.c:662: format '%lu' expects type 'long
unsigned int', but argument 6 has type 'apr_uint64_t'
subversion/libsvn_subr/svn_string.c: In function 'svn_cstring_strtoi64':
subversion/libsvn_subr/svn_string.c:706: format '%ld' expects type 'long
int', but argument 5 has type 'apr_int64_t'
subversion/libsvn_subr/svn_string.c:706: format '%ld' expects type 'long
int', but argument 6 has type 'apr_int64_t'

(These should use APR_[U]INT64_T_FMT. Doing so is complicated by the
fact that the format string localization tools don't like string
concatenation with macros, and there's no pool easily available to do a
temporary printf.)

- Julian
Received on 2010-09-15 15:35:40 CEST

This is an archived mail posted to the Subversion Dev mailing list.