Re: svn commit: r993258 - /subversion/trunk/subversion/mod_dav_svn/reports/log.c

On Tue, Sep 07, 2010 at 01:19:42PM +0530, Senthil Kumaran S wrote:
> Hi Bert,
>
> rhuijben_at_apache.org wrote:
> >Author: rhuijben
> >Date: Tue Sep 7 07:32:34 2010
> >New Revision: 993258
> >
> >URL: http://svn.apache.org/viewvc?rev=993258&view=rev
> >Log:
> >* subversion/mod_dav_svn/reports/log.c
> > (dav_svn__log_report): Partially revert r993246 to fix compilation.
> > The malformed_element_error() function is not defined nor a public
> > api.
>
> I was about to commit the attached patch in order to fix this, but I
> saw your commit before that. Since malformed_element_error() is used
> in many files I think we make this subversion private.

See r993310, which reports the error in a way that is in line with the error
handling elsewhere in dav_svn__log_report(). Note that there is a goto
statement involved, so we may not be able to re-use the
malformed_element_error() function after all.

Thanks,
Stefan
Received on 2010-09-07 12:13:21 CEST