Should you be using SVN_ERR_ASSERT() or one of its variants, here?
-Hyrum
On Sun, Sep 5, 2010 at 5:30 PM, <stefan2_at_apache.org> wrote:
> Author: stefan2
> Date: Sun Sep 5 22:30:09 2010
> New Revision: 992905
>
> URL: http://svn.apache.org/viewvc?rev=992905&view=rev
> Log:
> Format fix:
> Remove spaces between function name and the opening parentheses
>
> * subversion/libsvn_subr/svn_file_handle_cache.c
> (find_first, open_entry): fix calls to assert()
>
> Modified:
> subversion/branches/performance/subversion/libsvn_subr/svn_file_handle_cache.c
>
> Modified: subversion/branches/performance/subversion/libsvn_subr/svn_file_handle_cache.c
> URL: http://svn.apache.org/viewvc/subversion/branches/performance/subversion/libsvn_subr/svn_file_handle_cache.c?rev=992905&r1=992904&r2=992905&view=diff
> ==============================================================================
> --- subversion/branches/performance/subversion/libsvn_subr/svn_file_handle_cache.c (original)
> +++ subversion/branches/performance/subversion/libsvn_subr/svn_file_handle_cache.c Sun Sep 5 22:30:09 2010
> @@ -363,7 +363,7 @@ find_first(svn_file_handle_cache_t *cach
>
> /* the index must contain only used entries, i.e. those that actually
> * contain an open APR file handle. */
> - assert (!result || result->file);
> + assert(!result || result->file);
> return result;
> }
>
> @@ -552,7 +552,7 @@ open_entry(svn_file_handle_cache__handle
> apr_pool_t *pool)
> {
> /* any entry can be handed out to the application only once at any time */
> - assert (! entry->open_handle);
> + assert(!entry->open_handle);
>
> /* the entry will no longer be idle */
> remove_from_list(&cache->idle_entries, &entry->idle_link);
>
>
>
Received on 2010-09-06 20:54:38 CEST