[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn patch --add-to-cl

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Wed, 28 Jul 2010 22:40:02 +0300

Julian Foad wrote on Wed, Jul 28, 2010 at 15:38:01 +0100:
> On Sat, 2010-07-24, Daniel Shahaf wrote:
> > I've drilled a changelist into 'svn patch'.
> >
> > [[[
> > 0:% $svn st subversion
> > 0:% $svn patch ../diffs/svn-patch-add_to_cl.diff --add-to-cl cl
> > A [cl] subversion/tests/libsvn_client/client-test.c
> > U subversion/tests/libsvn_client/client-test.c
> [...]
> > 0:% $svn st --cl cl
> > --- Changelist 'cl':
> > M subversion/include/svn_client.h
> > M subversion/tests/libsvn_client/client-test.c
> [...]
> > ]]]
> >
> > Comments? Thoughts?
>
> You're talking about a totally new option, one that says "I'd like to
> add all the files affected to a (specified) changelist."
>
> That sounds like it could be a useful feature, but it doesn't sound like
> it should be specific to "svn patch" - if we have such a feature, I
> would expect to be able to use it with (more or less) all svn commands.
> Makes sense?
>

On one occasion I wanted to use it with 'svn add' (but for 'svn add' I think
it's closer to being syntactic sugar than with other commands). I see how
it would make sense for 'svn merge', too, since that too can add files.

BTW: dannas commented on IRC that the behaviour of 'svn patch --add-to-cl'
should be defined with respect to patches that don't apply successfully.
(so I don't plan to apply the patch without at least thinking a bit more
about that)

> - Julian
>
>
> > I haven't tested how it integrates with tree changes (files being
> > added/removed/moved/copied by 'svn patch') yet. In fact, I'm not sure what's
> > the current status of that: does 'svn patch' currently support tree operations
> > other than adding/removing files?
>
>
Received on 2010-07-28 21:42:11 CEST

This is an archived mail posted to the Subversion Dev mailing list.