Re: [PATCH v2] Make display_lines output a diff

On Mon, Jul 26, 2010 at 05:33:20PM +0530, Ramkumar Ramachandra wrote:
> Hi Stefan,
>
> Stefan Sperling writes:
> > Do all tests pass with it?
>
> Yes, they do. I ran `make check` and checked. I'm running it once
> more, just in case.

That's not neccessary. Your patch and the new diff output look quite nice.

I'd suggest to keep printing the actual and expected data, but also
print the diff output after printing the actual and expected data.

Is it possible to print unidiff-style diff headers with the python lib?
Like this:

--- old file
+++ new file
@@ 4,11 @@

Currently the headers look like:

*** old file
--- new file
***************
*** 4,11 ****

The advantage of the former would be that svn patch could parse it.
If that's not possible, fair enough, just keep the current header format.

Also, I'd print the diff the other way around. I'd like to see how the
EXPECTED text was changed by ACTUAL, i.e. the diff EXPECTED->ACTUAL.
Your patch does it the other way around. But maybe that's just me?

Thanks,
Stefan
Received on 2010-07-26 14:23:27 CEST