Re: svn commit: r979094 - /subversion/trunk/subversion/svnrdump/svnrdump.c

On Mon, Jul 26, 2010 at 05:25:10PM +0530, Ramkumar Ramachandra wrote:
> Hi Kamesh,
>
> Kamesh Jayachandran writes:
> > This breaks the 2 tests in svnrdump_tests.
> >
> >
> > Though the following inline patch may fix it you may have different plans
>
> Thanks! Yes, I'm aware that it breaks tests. Unfortunately, I have too
> many uncommitted changes, and I'm still waiting for them to be
> approved (see the three recent threads that I just bumped up) before I
> fix this.

Get more working copies. You need to be able to run tests on a change
in isolation before committing a change.

> About my plan: I'm going to add load support too, so this patch isn't
> generic enough.

What about doing one thing at a time instead?

I'm not trying to be sarcastic or offensive, but you seem to be trying
to juggle too many things at once. Writing good code takes time. Maybe
if you focused more thoroughly on single tasks with a bit more patience
and stopped jumping around a lot, you'd end up making more progress
quicke. Because that will also make reviewing easier for us, because
whenever you jump to a different task, we have to jump as well.

Do you have any diffs that will make svnrdump output match svnadmin
dump output more closely? Or maybe commits already done that I missed?

Thanks,
Stefan
Received on 2010-07-26 14:11:32 CEST