Re: svnrdump: New unittest

Ramkumar Ramachandra wrote on Sat, Jul 24, 2010 at 13:37:35 +0530:
> I'll commit it now.
>

Please don't "Approved by: danielsh"; I haven't +1'd the patch yet.

(e.g., I haven't run it yet)

> > First of all, please don't verify a 100k dumpfile during every 'make check'.
> > It would take too long.
>
> Ah, I didn't think about that.
>

Have you run 'make check'? :-)

> > Second, is it really necessary to have all of these? I'd assume that all edge
> > cases you need to test can be fitted quite roomly in a 50-revision dumpfile.
>
> Do we already have a dumpfile with all the possible edge cases
> somewhere in the tree?
>

svnsync_tests.py is probably what comes closest. (it also has some
svnsync-with-authz tests, IIRC)

> note that I've written special code for handling revision 0, so it makes
> sense to test it.

Agreed.
Received on 2010-07-24 10:17:21 CEST