Re: [PATCH] Add svnrdump

Hi,

Bert Huijben writes:
> > + /* Cleanup */
> > + SVN_ERR(svn_io_file_close(hb->temp_file, hb->pool));
> > + SVN_ERR(svn_stream_close(hb->temp_filestream));
>
> The standard handler already closes the stream for you and if you don't
> disown the file on mapping, this also closes the file.
>
> > + svn_pool_destroy(hb->pool);
>
> And as you clear the pool that contains the file and stream here, closing
> yourself is not necessary.

I realize this, but I closed the stream anyway to make debugging
easier. The pool is only destroyed much later. Do you think this is
bad policy?

-- Ram
Received on 2010-07-09 15:45:00 CEST