Re: svn commit: r958260 - /subversion/trunk/subversion/libsvn_client/diff.c

On Sat, Jun 26, 2010 at 13:56, <dannas_at_apache.org> wrote:
> Author: dannas
> Date: Sat Jun 26 17:56:06 2010
> New Revision: 958260
>
> URL: http://svn.apache.org/viewvc?rev=958260&view=rev
> Log:
> With SVN_EXPERIMENTAL_PATCH defined, only print the git diff header

I still don't understand why we have SVN_EXPERIMENTAL_PATCH. The whole
patch feature is in-progress. What "funny business" needs to be
protected? There is no legacy "right way" where changes need to be
excluded.

If you're altering the *diff* output, to enable some Git diff headers,
then please add a (cmdline) option to do that. The default can't
change for compat reasons, so the option will be required.

If this #define is protecting something else, then ... what? and why
would PATCH be in the name?

>...

Cheers,
-g
Received on 2010-06-26 22:48:25 CEST