[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r949964 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Tue, 01 Jun 2010 13:40:51 +0100

"Hyrum K. Wright" <hyrum_wright_at_mail.utexas.edu> writes:

>> scratch_pool);
>> - const char *properties = svn_sqlite__column_text(stmt, 6,
>> scratch_pool);
>> + apr_size_t props_size;
>> + const char *properties = svn_sqlite__column_blob(stmt, 6,
>> &props_size,
>> + scratch_pool);
>>
>
> Should we be using svn_sqlite__column_properties() here (and extending
> _bindf() so that it knows about properties)? I understand we're just doing
> a straight copy, so we don't necessarily need to parse and unparse the
> properties, but if this is the case, perhaps a comment in the code would be
> useful.

Perhaps. It's all temporary and will disappear when we centralise.

-- 
Philip
Received on 2010-06-01 14:41:32 CEST

This is an archived mail posted to the Subversion Dev mailing list.