RE: svn commit: r948785 - in /subversion/trunk/subversion: include/svn_client.h libsvn_client/deprecated.c libsvn_client/diff.c svn/cl.h svn/diff-cmd.c svn/log-cmd.c svn/main.c

> -----Original Message-----
> From: stylesen_at_apache.org [mailto:stylesen_at_apache.org]
> Sent: donderdag 27 mei 2010 13:08
> To: commits_at_subversion.apache.org
> Subject: svn commit: r948785 - in /subversion/trunk/subversion:
> include/svn_client.h libsvn_client/deprecated.c libsvn_client/diff.c svn/cl.h
> svn/diff-cmd.c svn/log-cmd.c svn/main.c
>
> Author: stylesen
> Date: Thu May 27 11:08:12 2010
> New Revision: 948785
>
> URL: http://svn.apache.org/viewvc?rev=948785&view=rev
> Log:
> Fix issue #3071.
>
> Request enhancement to svn diff to indicate that an external diff-cmd
> should NOT be used

Why don't you use the same method as --diff-cmd? (That seems like a much easier way to handle this enhancement)

--diff-cmd is only handled in subversion/svn/main.c:

(line 2095-2099)
/* XXX: Only diff_cmd for now, overlay rest later and stop passing
     opt_state altogether? */
  if (opt_state.diff_cmd)
    svn_config_set(cfg_config, SVN_CONFIG_SECTION_HELPERS,
                   SVN_CONFIG_OPTION_DIFF_CMD, opt_state.diff_cmd);

        Bert
Received on 2010-05-27 13:31:08 CEST