Re: [PATCH] readable error messages on non-ASCII systems, v2

(Cc'ing the dev@ list.)

On Fri, 2010-05-14, Greg Ames wrote:
> Fri, May 14, 2010, Julian Foad wrote:
> > In an attempt both to understand and to minimize the patch: would you
> > get the same result by converting 'err->message' from native encoding to
> > UTF-8 and then printing it in the way that it currently is printed?
>
> I had to adjust the patch to fit 1.5.6 (no SQLite here). Then
> svn_utf_* reported that there were non-UTF-8 characters at the
> beginning of the message. This time it was the "svn: " prefix passed
> to svn_cmdline_fprintf a few lines down. I changed the patch to also
> convert the prefix input variable to UTF-8 and pass that to
> svn_cmdline_fprintf, and I see readable error messages again.

Hi Greg. Great - it sounds like that gives you a less invasive solution
to that particular bit. Let us know how you get on.

- Julian
Received on 2010-05-17 11:25:41 CEST