Re: svn commit: r943445 - in /subversion/trunk/subversion: svn/cl.h svn/log-cmd.c svn/main.c tests/cmdline/getopt_tests_data/svn_help_log_switch_stdout

On Wed, May 12, 2010 at 7:24 AM, Stefan Sperling <stsp_at_elego.de> wrote:
> On Wed, May 12, 2010 at 10:59:28AM -0000, stsp_at_apache.org wrote:
>> Author: stsp
>> Date: Wed May 12 10:59:27 2010
>> New Revision: 943445
>>
>> URL: http://svn.apache.org/viewvc?rev=943445&view=rev
>> Log:
>> Add a new --show-diff option to svn log, fixing part of issue #2909.
>
>> +      SVN_ERR(svn_client_diff5(diff_options,
>> +                               lb->target_url,
>> +                               &start_revision,
>> +                               lb->target_url,
>> +                               &end_revision,
>> +                               NULL,
>> +                               svn_depth_infinity,
>> +                               FALSE, /* ignore ancestry */
>> +                               TRUE, /* no diff deleted */
>> +                               FALSE, /* show copies as adds */
>> +                               FALSE, /* ignore content type */
>
> BTW, I deliberately hard-coded the above options in the initial
> implementation. We could decide to leave it like this, given
> that svn log is not the primary tool to produce variants of diffs.
> I set these options with the goal of getting the shortest possible
> diff shown, with the exception of ignore_ancestry.

I don't want to pee in the punch bowl, but why are we doing this?
Especially if we cannot implement it sufficiently?

In terms of the implementation, how are you handling the log output in
XML when the user asks for diffs?

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/