Hi!
[[[
As part of WC-NG, remove a use of svn_wc_entry_t.
* subversion/libsvn_client/status.c
(svn_client_status5): Use svn_wc__node_is_status_added() instead of
checking entry->schedule. The check is meant to be used for
correctly determining when a node has been deleted in the repo
when running 'svn status -u'.
]]]
make check passes.
Since I've heard that all the easy replacements of svn_wc_entry_t has
already been done, I submit this patch for review. Am I missing
someting? Is there some cases when svn_wc_schedule_add does not equal
the output of svn_wc__node_status_is_added()?
I can think of the case of a replacement. That would be
svn_wc_schedule_replace for entry->schedule. But _is_status_deleted()
just returns that the node is added. Not a problem though, since we're
interrested in the cases where a path exists in a previous revision, if
we're doing a replace, the path must exist (e.g. be in BASE) in our wc.
Doing a test with two wc's from the same rev:
wc1>svn rm A/D/G/pi
wc1>svn ci -m ""
wc2>svn rm A/D/G/pi
wc2>touch A/D/G/pi
wc2>svn add A/D/G/pi
wc2>svn st
R A/D/G/pi
wc2>svn st -u
R * 1 A/D/G/pi
cheers,
Daniel
Received on 2010-04-18 14:15:26 CEST